Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: proposed changes for v2 schema #160

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Conversation

jgadling
Copy link
Contributor

This is a draft of the schema changes that are coming for the v2 api

Base automatically changed from jgadling/api-schema to main July 30, 2024 15:57
descriptive_name: degrees
symbol: °

alignment_local_alignment_file:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a https and an s3 path to this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'm not sure if we even want this field at all - we decided to keep all of the alignment data directly in the db rather than relying on files in s3 for alignment data cc @uermel ?

per_section_parameters:
range: PerSectionParameters
inverse: PerSectionParameters.frames
multivalued: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the relationship between the frame and per-section parameters be 1:1?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

each per-section parameters would map to a frame entry thru tiltseries and z-section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frames can (at least technically) have multiple per-section-parameters, one for each tiltseries.

tilt_offset:
exact_mappings:
- cdp-common:alignment_tilt_offset
local_alignment_file:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is different from the actual alignment. If that is a correct assumption, should we also add fields to capture the file path to the alignment file?

@jgadling jgadling merged commit 448421b into main Aug 16, 2024
4 checks passed
@jgadling jgadling deleted the jgadling/api-schema-v2 branch August 16, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants