-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: proposed changes for v2 schema #160
Conversation
schema/v1.1.0/common.yaml
Outdated
descriptive_name: degrees | ||
symbol: ° | ||
|
||
alignment_local_alignment_file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have a https and an s3 path to this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I'm not sure if we even want this field at all - we decided to keep all of the alignment data directly in the db rather than relying on files in s3 for alignment data cc @uermel ?
schema/v1.1.0/api_models.yaml
Outdated
per_section_parameters: | ||
range: PerSectionParameters | ||
inverse: PerSectionParameters.frames | ||
multivalued: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the relationship between the frame and per-section parameters be 1:1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
each per-section parameters would map to a frame entry thru tiltseries and z-section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frames can (at least technically) have multiple per-section-parameters, one for each tiltseries.
schema/v1.1.0/api_models.yaml
Outdated
tilt_offset: | ||
exact_mappings: | ||
- cdp-common:alignment_tilt_offset | ||
local_alignment_file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is different from the actual alignment. If that is a correct assumption, should we also add fields to capture the file path to the alignment file?
7821437
to
bf7c59a
Compare
bf7c59a
to
039c043
Compare
This is a draft of the schema changes that are coming for the v2 api